Added Future::flatten #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
requested changes
Nov 3, 2019
ghost
requested a review
from 
taiki-e
reviewed
Nov 3, 2019
Darksonn
reviewed
Nov 3, 2019
|
I'd be okay with using unsafe methods on the |
taiki-e
reviewed
Nov 5, 2019
taiki-e
approved these changes
Nov 5, 2019
yoshuawuyts
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
Looks great! -- going to create a separate PR for @taiki-e's comment in a follow-up PR. Fantastic work @portgasd666!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial attempt at implementing Future::flatten (#404)